Skip to content

ci: fix release template generation (again)#801

Merged
Ron (rjaegers) merged 1 commit into
mainfrom
feature/fix-release-template-generation
May 20, 2025
Merged

ci: fix release template generation (again)#801
Ron (rjaegers) merged 1 commit into
mainfrom
feature/fix-release-template-generation

Conversation

@rjaegers
Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This PR fixes the release note generation by specifying the correct path to the template.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings May 20, 2025 06:11
@rjaegers Ron (rjaegers) requested a review from a team as a code owner May 20, 2025 06:11
@rjaegers Ron (rjaegers) enabled auto-merge May 20, 2025 06:11
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes the release note generation step by pointing to the correct template location in the repository.

  • Updates the cat command to use the full GITHUB_WORKSPACE path for RELEASE_TEMPLATE.md
Comments suppressed due to low confidence (1)

.github/workflows/release-please.yml:38

  • Add a check to verify that the RELEASE_TEMPLATE.md file exists before reading it, so the workflow fails fast if the template path is incorrect.
TEMPLATE=$(cat "$GITHUB_WORKSPACE/.github/RELEASE_TEMPLATE.md")

@github-actions
Copy link
Copy Markdown
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:2802245eed59af7dcec416bca552855439e336628920c3498eb474ca731c5af2

OS/Platform Previous Size Current Size Delta
linux/amd64 480.63M 480.63M 0.00 (+0.00%)
linux/arm64 432.10M 432.10M 0.00 (+0.00%)

@github-actions
Copy link
Copy Markdown
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:15a6e0abe8d0f946f286bfe7a6fc64a9e70552f89466f716a9c818a88b8cbceb

OS/Platform Previous Size Current Size Delta
linux/amd64 690.59M 690.59M 0.00 (+0.00%)
linux/arm64 672.74M 672.74M 0.00 (+0.00%)

@github-actions
Copy link
Copy Markdown
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ DOCKERFILE hadolint 2 0 0 0.7s
✅ GHERKIN gherkin-lint 2 0 0 1.1s
✅ JSON npm-package-json-lint yes no no 0.41s
✅ JSON prettier 15 1 0 0 0.39s
✅ JSON v8r 15 0 0 8.84s
✅ MARKDOWN markdownlint 9 0 0 0 0.76s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.27s
✅ REPOSITORY checkov yes no no 16.12s
✅ REPOSITORY gitleaks yes no no 0.32s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 21.46s
✅ REPOSITORY secretlint yes no no 0.91s
✅ REPOSITORY syft yes no no 0.96s
✅ REPOSITORY trivy yes no no 4.91s
✅ REPOSITORY trivy-sbom yes no no 0.1s
✅ REPOSITORY trufflehog yes no no 3.39s
✅ SPELL lychee 60 0 0 1.8s
✅ YAML prettier 22 0 0 0 0.73s
✅ YAML v8r 22 0 0 6.6s
✅ YAML yamllint 22 0 0 0.67s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 2 files  ±0   2 suites  ±0   1m 16s ⏱️ -1s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9bb12f3. ± Comparison against base commit 2cfe718.

@rjaegers Ron (rjaegers) added this pull request to the merge queue May 20, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 20, 2025
@rjaegers Ron (rjaegers) added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 7ceafa1 May 20, 2025
23 checks passed
@rjaegers Ron (rjaegers) deleted the feature/fix-release-template-generation branch May 20, 2025 14:08
@github-actions
Copy link
Copy Markdown
Contributor

Pull Request Report (#801)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 1
Number of changed files 1
Number of commits 1
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 7.9 Hours
Time that was spend on the branch before the PR was created 1 Min
Time that was spend on the branch before the PR was merged 8 Hours
Time to merge after last review 4.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 27.7 Min
Total time spend in last status check run on PR 12.2 Min

@github-actions
Copy link
Copy Markdown
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants